Eager workflow start sample #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Oct 9, 2025
cretz
reviewed
Oct 9, 2025
| * [context_propagation](context_propagation) - Use interceptors to propagate thread/fiber local data from clients | ||
| through workflows/activities. | ||
| * [dsl](dsl) - Demonstrates having a workflow interpret/invoke arbitrary steps defined in a DSL. | ||
| * [eager_wf_start](eager_wf_start) - Demonstrates Eager Workflow Start to reduce latency for workflows that start with a local activity. |
Member
There was a problem hiding this comment.
Similar to .NET suggestion, can we use the full term workflow here?
| require_relative 'eager_workflow' | ||
| require_relative 'greeting_activity' | ||
|
|
||
| TASK_QUEUE = 'eager-wf-start-task-queue' |
Member
There was a problem hiding this comment.
Usually our samples have a <sample-name>-sample task queue name, so can we remove -task-queue and add -sample?
| handle = client.start_workflow( | ||
| EagerWfStart::EagerWorkflow, | ||
| 'Temporal', | ||
| id: "eager-workflow-id-#{SecureRandom.uuid}", |
Member
There was a problem hiding this comment.
Our samples have traditionally not used random identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Simple sample showing how to use eager workflow start with a local activity.
Why?
Show a sample use case of eager workflow start (i.e. a workflow with a local activity).
How was this tested:
Sample runs correctly. There does not seem to be a way to verify that a worker has started eagerly in ruby SDK
Any docs updates needed?
No